Skip to content

texture_size,3d_texture,compressed_format tests fail for ASTC formats #4380

@beaufortfrancois

Description

@beaufortfrancois

The following texture_size,3d_texture,compressed_format tests fail for ASTC formats when adding experimental texture-compression-astc-sliced-3d feature support at https://ci.chromium.org/ui/p/chromium/builders/try/dawn-mac-arm64-deps-rel/14805/test-results?sortby=&groupby=

webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x10-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x10-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x10-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x10-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x6-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x6-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x8-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x8-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x8-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-10x8-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x10-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x10-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x10-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x10-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x12-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x12-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x12-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-12x12-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x4-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x4-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x4-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x4-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-5x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x6-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-6x6-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x5-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x5-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x6-unorm"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x6-unorm-srgb"
webgpu:api,validation,createTexture:texture_size,3d_texture,compressed_format:format="astc-8x6-unorm-srgb"

I believe it happens because it fails this assertion:

assert(
maxTextureDimension3D % info.blockWidth === 0 &&
maxTextureDimension3D % info.blockHeight === 0
);

I removed it locally and it worked "fine".

It's not clear though if it's safe to be removed. @greggman What do you think?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions