Skip to content

wgsl: Add CTS tests for WGSL limits#3389

Merged
jrprice merged 2 commits into
gpuweb:mainfrom
jrprice:limits
May 7, 2024
Merged

wgsl: Add CTS tests for WGSL limits#3389
jrprice merged 2 commits into
gpuweb:mainfrom
jrprice:limits

Conversation

@jrprice
Copy link
Copy Markdown
Contributor

@jrprice jrprice commented Feb 12, 2024

Fixes #1710
Fixes #1956


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Comment thread src/webgpu/shader/execution/limits.spec.ts Outdated
@jrprice jrprice marked this pull request as ready for review May 7, 2024 17:20
@jrprice jrprice changed the title WIP: Add CTS tests for WGSL limits wgsl: Add CTS tests for WGSL limits May 7, 2024
@jrprice jrprice assigned dj2 and unassigned dj2 May 7, 2024
@jrprice jrprice requested a review from dj2 May 7, 2024 17:20
@jrprice jrprice merged commit 8fc37a5 into gpuweb:main May 7, 2024
@jrprice jrprice deleted the limits branch May 7, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wgsl: brace-enclosed statement nesting depth limited to 127 wgsl: Validate limits

3 participants