Skip to content

Fix typo in test name: "disjoinRanges" should be "disjointRanges". #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix typo in test name: "disjoinRanges" should be "disjointRanges". #3838

merged 2 commits into from
Jul 11, 2024

Conversation

@jimblandy
Copy link
Contributor

@jimblandy jimblandy commented Jul 3, 2024

The test:

api,validation,buffer,mapping:getMappedRange,disjoinRanges_many

should be named ...,disjointRanges_many. Fix the TypeScript and the corresponding entry in the timing estimates file.

This PR is pretty minimal, so I didn't file an issue, and I didn't fill in the author's checklist. If that's a problem, just let me know.

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@jimblandy
Fix typo in test name: "disjoinRanges" should be "disjointRanges".
458599b 
The test:

    api,validation,buffer,mapping:getMappedRange,disjoinRanges_many

should be named `...,disjointRanges_many`. Fix the TypeScript and the
corresponding entry in the timing estimates file.
kainino0x
kainino0x approved these changes Jul 11, 2024
View reviewed changes
src/webgpu/api/validation/buffer/mapping.spec.ts
});

g.test('getMappedRange,disjoinRanges_many')
g.test('getMappedRange,disjointRanges_many')
Copy link
Collaborator

@kainino0x kainino0x Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'd say this should be disjoint_ranges_many or disjoint_ranges,many since "disjointRanges" doesn't refer to a camelCase thing from the API spec...
However that is not a very important rule and we'd have to update two tests to fix that so LGTM

@kainino0x kainino0x enabled auto-merge (squash) July 11, 2024 23:44
@kainino0x kainino0x merged commit 79c4db9 into gpuweb:main Jul 11, 2024
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 20, 2024
@ErichDonGubler
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
e564340 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also @jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 21, 2024
@ErichDonGubler
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
4eabb36 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also @jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Aug 22, 2024
@ErichDonGubler
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
17480e7 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also @jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Aug 23, 2024
@marco-c
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
8ea461c 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376

UltraBlame original commit: e7b536d026a25476d4107d76137201074bf07a80
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Aug 23, 2024
@marco-c
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
784c9f0 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376

UltraBlame original commit: e7b536d026a25476d4107d76137201074bf07a80
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
@ErichDonGubler
Bug 1909753, part 2.5 - trivially moved tests, no action required r=w…
9afb95d 
…ebgpu-reviewers,teoxoy

- `webpgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many` was renamed to `disjointRanges_many` (see also @jimb's PR making the move at [gpuweb/cts#3838](gpuweb/cts#3838))
- `webgpu:shader,validation,decl,ptr_spelling:*` was merged with `webgpu:shader,validation,types,pointer:*` in [`gpuweb/cts`#3714](gpuweb/cts#3714).
- `webgpu:shader,validation,{decl,var_access_mode,parse,var_and_let}:*` → `webgpu:shader,validation,decl,var:*`, merged in [gpuweb/cts#3713](https:// github.com/gpuweb/cts/pull/3713).
  - `…:initializer_type:*` had its structure changed to accommodate the merge.
- `webgpu:shader,validation,parse,align:*` → `webgpu:shader,validation,shader_io,align:*`, moved by [gpuweb/cts#3712](gpuweb/cts#3712),
- `webgpu:shader,validation,parse,{break,break_if,compound,const_assert,continuing,discard,statement_behavior}`, moved by [gpuweb/cts#3742](gpuweb/cts#3742)
  - `webgpu:shader,validation,parse,break_if:non_bool_param:*` → `webgpu:shader,validation,statement,break_if:condition_type:*`, moved by [gpuweb/cts#3671](gpuweb/cts#3671), affected by [`gpuweb/cts`#3690](gpuweb/cts#3690).
- `webgpu:shader,validation,parse_binary_ops:*` → `webgpu:shader,validation,expression,binary,parse:*`

This list is likely incomplete, because I _really_ needed to make this tractable. Sorry! I upkept the above for my own sanity, and think it's interesting for record-keeping, but not necessary useful for a reviewer.

Differential Revision: https://phabricator.services.mozilla.com/D219376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

@alan-baker alan-baker alan-baker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimblandy @kainino0x @alan-baker