Skip to content

Fix typo in test name: "disjoinRanges" should be "disjointRanges". #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix typo in test name: "disjoinRanges" should be "disjointRanges". #3838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458599b
Fix typo in test name: "disjoinRanges" should be "disjointRanges".
jimblandy Jul 3, 2024
62746b2
Merge branch 'main' into test-name-typo-disjoinranges
kainino0x Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/webgpu/api/validation/buffer/mapping.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,7 +943,7 @@ g.test('getMappedRange,disjointRanges')
t.testGetMappedRangeCall(success, buffer, offset2, size2);
});

g.test('getMappedRange,disjoinRanges_many')
g.test('getMappedRange,disjointRanges_many')
Copy link
Collaborator

@kainino0x kainino0x Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I'd say this should be disjoint_ranges_many or disjoint_ranges,many since "disjointRanges" doesn't refer to a camelCase thing from the API spec...
However that is not a very important rule and we'd have to update two tests to fix that so LGTM

.desc('Test getting a lot of small ranges, and that the disjoint check checks them all.')
.fn(async t => {
const kStride = 256;
Expand Down
2 changes: 1 addition & 1 deletion src/webgpu/listing_meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@
"webgpu:api,validation,buffer,destroy:while_mapped:*": { "subcaseMS": 1.150 },
"webgpu:api,validation,buffer,mapping:gc_behavior,mapAsync:*": { "subcaseMS": 32.200 },
"webgpu:api,validation,buffer,mapping:gc_behavior,mappedAtCreation:*": { "subcaseMS": 76.200 },
"webgpu:api,validation,buffer,mapping:getMappedRange,disjoinRanges_many:*": { "subcaseMS": 73.700 },
"webgpu:api,validation,buffer,mapping:getMappedRange,disjointRanges_many:*": { "subcaseMS": 73.700 },
"webgpu:api,validation,buffer,mapping:getMappedRange,disjointRanges:*": { "subcaseMS": 2.257 },
"webgpu:api,validation,buffer,mapping:getMappedRange,offsetAndSizeAlignment,mapped:*": { "subcaseMS": 3.119 },
"webgpu:api,validation,buffer,mapping:getMappedRange,offsetAndSizeAlignment,mappedAtCreation:*": { "subcaseMS": 5.611 },
Expand Down