Test GPUBuffer in GPUBindingResource

[beaufortfrancois]

Spec PR: gpuweb/gpuweb#5193

---

Requirements for PR author:

• All missing test coverage is tracked with "TODO" or .unimplemented().
• New helpers are /** documented */ and new helper files are found in helper_index.txt.
• Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) They pass in a Chromium build patched with https://chromium-review.googlesource.com/c/chromium/src/+/6549638
• Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

• Tests are properly located in the test tree.
• Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
• Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
• Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

[Kangz]

Suggested change

	const bufferData = new Uint8Array(bufferSize);
	const bufferData = new Uint32Array(bufferSize / 4);

[Kangz]

optional nit

[beaufortfrancois]

This forces me to add / 4 in other places so if that's okay, I'll leave it as is.

[Kangz]

Sounds good.

[Kangz]

We could avoid generating the subcases with offset / size when bindBufferResource is true. Also bufferSize could be extraBufferSize: [0, 8] and the computation done in the test.

[beaufortfrancois]

Done

[greggman]

just a nit but I'd never guess to look for binding buffer tests in src/webgpu/api/operation/compute/basic.spec.ts. Should we move them somewhere else or are they fine here?

[Kangz]

Ah yeah that's super odd.

[beaufortfrancois]

Where would you move them? Something like a new file called src/webgpu/api/operation/buffers/createBindGroup.ts?

[Kangz]

Sure that would work.

[beaufortfrancois]

@Kangz Done

[beaufortfrancois]

@greggman I'd like to roll gpuweb/types#182 into the CTS but I'd like to avoid defining texture formats for texture-formats-tier1. Do you know if there's a way to override GPUTextureFormats type to say "exclude r16unorm, etc" for now?

[greggman]

@greggman I'd like to roll gpuweb/types#182 into the CTS but I'd like to avoid defining texture formats for texture-formats-tier1. Do you know if there's a way to override GPUTextureFormats type to say "exclude r16unorm, etc" for now?

That doesn't appear to be possible and it's not entirely clear we want to make it possible. There are compile time checks that all the GPUTextureFormat formats have corresponding data. We'd have to removing those checks to make it possible.

I'll try to put up a PR that rolls the types and adds what's needed to keep running.

[greggman]

pr to roll types #4400

[beaufortfrancois]

pr to roll types #4400

Thank you very much @greggman!