Change .getQueue() to .defaultQueue #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdashg
approved these changes
Nov 7, 2019
|
Good call. I would support that. |
|
Resolution from the 2019-11-11 meeting: have it be a |
It's expected that we'll add multi-queue support to WebGPU. To prepare for this, change .getQueue() to .defaultQueue under the expectation that adding multi-queue should be a non-breaking addition to the API. This change should make the current API safe for the multi-queue future.
kainino0x
force-pushed
the
getdefaultqueue
branch
from
d3d1f7e to
24b9fdb
Compare
|
Done, PTAL |
|
LGTM, I think this is safe to merge given we agreed to this in the meeting. |
|
Realized right after sending it I should add a SameObject attribute to it. |
|
We'll want some SameObjects in other places too, but I'll make another PR. |
kainino0x
changed the title
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 18, 2019
In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9
Kangz
added a commit
to gpuweb/types
that referenced
this pull request
Nov 18, 2019
This follows changes in gpuweb/gpuweb#490
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 18, 2019
In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 18, 2019
In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116}
romandev
added a commit
to romandev/cts
that referenced
this pull request
Nov 18, 2019
Spec changes: gpuweb/gpuweb#490
kainino0x
pushed a commit
to gpuweb/cts
that referenced
this pull request
Nov 27, 2019
Spec changes: gpuweb/gpuweb#490
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallezchromium.org> Commit-Queue: Corentin Wallez <cwallezchromium.org> Cr-Commit-Position: refs/heads/master{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295 UltraBlame original commit: ead6f4061c164022a0577beeddbbd6d7d51fc40b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallezchromium.org> Commit-Queue: Corentin Wallez <cwallezchromium.org> Cr-Commit-Position: refs/heads/master{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295 UltraBlame original commit: ead6f4061c164022a0577beeddbbd6d7d51fc40b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallezchromium.org> Commit-Queue: Corentin Wallez <cwallezchromium.org> Cr-Commit-Position: refs/heads/master{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295 UltraBlame original commit: ead6f4061c164022a0577beeddbbd6d7d51fc40b
13 tasks
michaldybizbanski
added a commit
to michaldybizbanski/gpuweb
that referenced
this pull request
May 1, 2020
kainino0x
pushed a commit
that referenced
this pull request
May 1, 2020
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
* Add test for zero sized index buffer out of bounds draw * fix
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
…eue, a=testonly Automatic update from web-platform-tests WebGPU: Change .getQueue() to .defaultQueue In an effort to support multi-queue with WebGPU, the shape of the API has changed in the spec side[1]. [1] gpuweb/gpuweb#490 Bug: 852089 Change-Id: I6971ef859f4af1b94663589039009d416f1bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919531 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#716116} -- wpt-commits: 23ff72fee1280b19364f14ec2f0f5e6a867d4b88 wpt-pr: 20295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's expected that we'll add multi-queue support to WebGPU. To prepare
for this, rename getQueue to getDefaultQueue under the assumption
(/recommendation) that adding multi-queue should be a non-breaking
addition to the API. This change should make the current API safe for
the multi-queue future.
Preview | Diff