Skip to content

Graasp file import#1807

Merged
MatveyK merged 7 commits into
mainfrom
1677-graasp-import
May 8, 2025
Merged

Graasp file import#1807
MatveyK merged 7 commits into
mainfrom
1677-graasp-import

Conversation

@MatveyK
Copy link
Copy Markdown
Contributor

@MatveyK MatveyK commented Apr 8, 2025

No description provided.

@MatveyK MatveyK self-assigned this Apr 8, 2025
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward for tests 👀

Comment thread src/services/item/plugins/importExport/service.ts Outdated
@MatveyK MatveyK force-pushed the 1677-graasp-import branch 4 times, most recently from cac63bd to c0d9e38 Compare April 23, 2025 09:29
@MatveyK MatveyK requested a review from pyphilia April 23, 2025 09:30
@MatveyK MatveyK force-pushed the 1677-graasp-import branch 2 times, most recently from 1db67ad to 3f82314 Compare April 24, 2025 09:01
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and rebase ✨

Could you write some documentation of what is handled or not currently? There is a specifications.md file in /importExport that roughly describes the raw import.

Comment thread src/services/item/item.service.ts Outdated
Comment thread src/services/item/plugins/importExport/service.ts Outdated
Comment thread src/services/item/plugins/file/itemFile.service.ts
@MatveyK MatveyK force-pushed the 1677-graasp-import branch from 3f82314 to e47599c Compare April 29, 2025 13:41
@MatveyK
Copy link
Copy Markdown
Contributor Author

MatveyK commented Apr 29, 2025

Added details to the specifications.md, fixed the issues. Just waiting for the #1839 to get merged.

@MatveyK MatveyK force-pushed the 1677-graasp-import branch from e47599c to 8aef49f Compare April 29, 2025 14:56
@MatveyK MatveyK requested a review from pyphilia April 29, 2025 14:58
@MatveyK MatveyK force-pushed the 1677-graasp-import branch 2 times, most recently from a364cb5 to 119f2ee Compare May 1, 2025 13:32
@MatveyK MatveyK force-pushed the 1677-graasp-import branch from 119f2ee to 7e9f6b2 Compare May 6, 2025 08:47
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2025

@MatveyK MatveyK enabled auto-merge May 6, 2025 14:00
@MatveyK MatveyK added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 09fa558 May 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants