Conversation
|
Contributor
Author
|
Because of one library that is in esm, the build for jest was failing. I downgraded ts-jest. Another solution would be to use |
spaenleh
approved these changes
May 1, 2025
Member
spaenleh
left a comment
spaenleh
left a comment
There was a problem hiding this comment.
Very nice ! Indeed we could investigate using isolated modules. But I think it requires some refactoring of incorrect code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow back patch, put, delete and options in cors.
Given #1358 it would be better to not decorate the options. For simplicity I just added the necessary option.