Skip to content

fix: allow to post twice a like on an item#1864

Merged
spaenleh merged 2 commits into
mainfrom
1863-duplicate-post-itemlike
May 23, 2025
Merged

fix: allow to post twice a like on an item#1864
spaenleh merged 2 commits into
mainfrom
1863-duplicate-post-itemlike

Conversation

@spaenleh
Copy link
Copy Markdown
Member

@spaenleh spaenleh commented May 5, 2025

In this PR:

@spaenleh spaenleh requested a review from pyphilia May 5, 2025 14:36
@spaenleh spaenleh self-assigned this May 5, 2025
@spaenleh spaenleh added the bug 🪲 Something isn't working label May 5, 2025
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added suggestion for more precise test check, but overrall LGTM 🎣

Comment thread src/services/item/plugins/itemLike/itemLike.schemas.ts Outdated
Comment thread src/services/item/plugins/itemLike/itemLike.controller.test.ts
@spaenleh spaenleh force-pushed the 1863-duplicate-post-itemlike branch from ef57e3e to 39949c1 Compare May 23, 2025 07:08
@sonarqubecloud
Copy link
Copy Markdown

@spaenleh spaenleh added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit b5b2180 May 23, 2025
8 checks passed
@spaenleh spaenleh deleted the 1863-duplicate-post-itemlike branch May 23, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working v2.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST item like if already liked throws a 500 Internal on duplicate key

2 participants