feat: send email for export raw#1881
Merged
Merged
Conversation
spaenleh
requested changes
May 28, 2025
Member
spaenleh
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I have left comments related to general naming, we can decide to change them or not. I see quite a lot of the names would need to be changed.
Some of the comments are a bit nitpicking. Let me know.
Contributor
Author
Member
|
@pyphilia I think adding an ellipsis defies the purpose of putting the link in plain text. users should be able to copy the link if needed even if it is not recognized by the email client. What does the plain text variant look like ? |
Contributor
Author
spaenleh
approved these changes
Jun 2, 2025
added 7 commits
June 2, 2025 07:27
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







For exporting, the zip creation is handled in the background and a download mail is sent. Meanwhile the request responds with 202 accepted.
The export request is logged in a corresponding table. Currently it does not do anything.
Expiration date is 7 days. Nothing cleans up after 7 days.
!! guests cannot use export. So we should use
/downloadfor downloading.Following this PR we will:
I didn't reuse
action_request_exportas we might want different schemas for actions export (json, csv) and item themselves (raw, graasp). We might want different expiration time, also we might want export not related to items (eg. export member data).TODO