refactor: simplify environment variables#1897
Merged
Merged
Conversation
|
spaenleh
approved these changes
Jun 6, 2025
Member
spaenleh
left a comment
spaenleh
left a comment
There was a problem hiding this comment.
Very nice ! this looks so much better, thank you so much !
Member
|
@pyphilia I have marked the SonarCloud issue related to SSL and SMTP as |
Contributor
Author
|
Since we are hosting on aws, I think they don't even allow you to use smtp without security. Even dev is setup with |
Member
|
Yes, with "production" I meant anything not in local dev. So the answer is yes. Thank you for confirming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new env:
REDIS_CONNECTION,MAILER_CONNECTIONRemove:
MAILER_CONFIG_SMTP_HOSTMAILER_CONFIG_SMTP_PORTMAILER_CONFIG_SMTP_USE_SSLMAILER_CONFIG_USERNAMEMAILER_CONFIG_PASSWORDREDIS_HOSTREDIS_PORTREDIS_PASSWORDREDIS_USERNAMEAUTH_TOKEN_EXPIRATION_IN_MINUTESREFRESH_TOKEN_EXPIRATION_IN_MINUTESPASSWORD_RESET_JWT_EXPIRATION_IN_MINUTESEMAIL_CHANGE_JWT_EXPIRATION_IN_MINUTES