Skip to content

fix: action.view migration to remove explorer and add home and analytics#1920

Merged
spaenleh merged 3 commits into
mainfrom
action-view-migration
Jun 25, 2025
Merged

fix: action.view migration to remove explorer and add home and analytics#1920
spaenleh merged 3 commits into
mainfrom
action-view-migration

Conversation

@spaenleh
Copy link
Copy Markdown
Member

@spaenleh spaenleh commented Jun 24, 2025

In this PR:

  • remove the "explorer" value from the action.view enum ⚠️ REQUIRES A MIGRATION ⚠️
  • update sdk (code changes make the return type of getContextFromLink have a better type and it clashes with the current implementation)

fix #1900

@spaenleh spaenleh force-pushed the action-view-migration branch from 3575dc4 to 0485821 Compare June 24, 2025 12:56
@spaenleh spaenleh requested a review from pyphilia June 24, 2025 12:56
@spaenleh spaenleh self-assigned this Jun 24, 2025
@spaenleh spaenleh added bug 🪲 Something isn't working chore Generic task or chore labels Jun 24, 2025
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've added some minor comments.

Comment thread src/services/action/action.service.ts Outdated
@sonarqubecloud
Copy link
Copy Markdown

@spaenleh
Copy link
Copy Markdown
Member Author

@pyphilia in light of what we discussed concerning excluding or not analytics, I chose to add it, we can always decide to not include it in the exports or in computations if required.

@spaenleh spaenleh changed the title fix: action.view migration for explorer value fix: action.view migration to remove explorer and add home and analytics Jun 24, 2025
@spaenleh spaenleh added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit bea9a5a Jun 25, 2025
8 checks passed
@spaenleh spaenleh deleted the action-view-migration branch June 25, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working chore Generic task or chore v2.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

actionViewEnum references deprecated view explorer

2 participants