Skip to content

refactor: pass account id instead of complete account to authorization#1924

Merged
pyphilia merged 2 commits into
mainfrom
authorization-account-id
Jul 1, 2025
Merged

refactor: pass account id instead of complete account to authorization#1924
pyphilia merged 2 commits into
mainfrom
authorization-account-id

Conversation

@pyphilia
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia commented Jun 30, 2025

Refactor AuthorizedItemService to use accountId instead of a full member props.
This PR only updates one level, which means only functions from the AuthorizedItemService service. Some caller functions could be optimised by using "id" only, but it not in the scope of the PR.

Rename some arguments called actor for a more accurate name.

@pyphilia pyphilia requested a review from spaenleh June 30, 2025 10:19
@pyphilia pyphilia self-assigned this Jun 30, 2025
Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! See my comment

Comment thread src/services/itemMembership/membership.service.ts Outdated
@pyphilia pyphilia requested a review from spaenleh June 30, 2025 14:03
@pyphilia pyphilia marked this pull request as ready for review June 30, 2025 14:45
@pyphilia pyphilia force-pushed the authorization-account-id branch from c747552 to 5f551fd Compare June 30, 2025 14:45
Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay ! 🎉

@pyphilia pyphilia force-pushed the authorization-account-id branch from 5f551fd to cc39640 Compare July 1, 2025 11:57
@pyphilia pyphilia enabled auto-merge July 1, 2025 11:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 1, 2025

@pyphilia pyphilia added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit fe737ae Jul 1, 2025
8 checks passed
@pyphilia pyphilia deleted the authorization-account-id branch July 1, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants