Skip to content

feat: setup yjs for collaboration in pages#1959

Merged
pyphilia merged 5 commits into
mainfrom
1958-page-collab
Jul 25, 2025
Merged

feat: setup yjs for collaboration in pages#1959
pyphilia merged 5 commits into
mainfrom
1958-page-collab

Conversation

@pyphilia
Copy link
Copy Markdown
Contributor

@pyphilia pyphilia commented Jul 23, 2025

Setup yjs server to handle collaboration in pages.
Check write permission of the user over the page.

Server code comes from https://github.com/yjs/y-websocket-server/
Content is not saved yet.

close #1958

@pyphilia pyphilia requested a review from spaenleh July 23, 2025 14:00
@pyphilia pyphilia self-assigned this Jul 23, 2025
Comment thread src/services/item/plugins/page/server/utils.ts Fixed
Comment thread src/services/item/plugins/page/server/utils.ts Fixed
Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good ! I just have a suggestion to move the itemId from a query string to a path param.

Comment thread src/services/item/plugins/page/page.controller.ts Outdated
Comment thread src/services/item/plugins/page/page.schemas.ts Outdated
@pyphilia pyphilia enabled auto-merge July 25, 2025 12:59
@sonarqubecloud
Copy link
Copy Markdown

@pyphilia pyphilia added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit d773276 Jul 25, 2025
8 checks passed
@pyphilia pyphilia deleted the 1958-page-collab branch July 25, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup collaboration for pages with yjs

3 participants