Skip to content

feat(page): gracefully fallback on error#1970

Merged
pyphilia merged 3 commits into
mainfrom
page-gracefully-fallback
Aug 28, 2025
Merged

feat(page): gracefully fallback on error#1970
pyphilia merged 3 commits into
mainfrom
page-gracefully-fallback

Conversation

@pyphilia
Copy link
Copy Markdown
Contributor

to be rebase on #1969

Close connection(s) when an error happens, mainly dealing with wrong update messages.

Context: I discovered the error because I opened a faulty page locally, which made the server crash.

@pyphilia pyphilia requested a review from spaenleh August 21, 2025 14:47
@pyphilia pyphilia self-assigned this Aug 21, 2025
@pyphilia pyphilia force-pushed the page-gracefully-fallback branch from 140df59 to 4ce340b Compare August 25, 2025 07:35
Copy link
Copy Markdown
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Comment thread src/services/item/plugins/page/page.service.ts Outdated
@pyphilia pyphilia enabled auto-merge August 28, 2025 09:55
@sonarqubecloud
Copy link
Copy Markdown

@pyphilia pyphilia added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit 6bca256 Aug 28, 2025
8 checks passed
@pyphilia pyphilia deleted the page-gracefully-fallback branch August 28, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants