This repository was archived by the owner on Jan 23, 2025. It is now read-only.
refactor: use graasp button#305
Merged
Merged
Conversation
Contributor
|
I have tested
|
Contributor
Author
|
@alvrba Indeed you're right, the app is crashing (I did it quite quickly yesterday). The problems comes from both react-scripts v5 and uppy react/create-react-app#12021 I've downgraded react-scripts. Though the whole idea was to remove the security alerts but I guess we will keep them for the time being. And we want to replace all the buttons yes! |
6a22bb5 to
eb3cabe
Compare
alvrba
approved these changes
Mar 29, 2022
9891a11 to
70a979a
Compare
70a979a to
19d1cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some properties in TextEditor / DocumentItem corresponding to the changes in graasp-ui.
It also removes all buttons to use the Button in @graasp/ui.
close #304