Add dependabot #54
Closed
Add dependabot #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan M. <StefMa@users.noreply.github.com>
Contributor
Author
|
@ov7a could may have a look? 🙃 |
Member
|
@StefMa I'm not sure about this. While having updates is good, I don't feel that the test coverage is strong enough to blindly merge them. And reviewing/testing/managing dependabot PRs usually is annoying. |
Contributor
Author
|
What types of /more tests would be required to feel save for the current
dependencies (gson)? 🤔
I could also write a few for that.
Beside of that... Gson doesn't get too many updates anymore. The last
update happen a year ago, the one before that 2 years ago 😁
But nevermind, I could also close this PR if you're not interested in it 👍
…On Wed, Jan 24, 2024, 8:28 AM Vlad Chesnokov ***@***.***> wrote:
@StefMa <https://github.com/StefMa> I'm not sure about this. While having
updates is good, I don't feel that the test coverage is strong enough to
blindly merge them. And reviewing/testing/managing dependabot PRs usually
is annoying.
—
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOBQ6ZSSYFRXF562ADNI6TYQCZY7AVCNFSM6AAAAABAE7B4K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGU2DIMZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@StefMa It's not like I'm against it, I just don't feel it's worth it. Let's hear other opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes a bit further of #52 and adds dependabot to make sure we are always using the latest versions of dependencies 🙃.
I copied the config from here and removed the dummy auth (because this is not required).