Omit repository_url for Maven central #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maven central repo (https://repo.maven.apache.org/m2) is the default repository URL for any maven PURLs. For dependencies resolved from Maven central, a repository_url value is no longer included in the generated PURL.
sschuberth
reviewed
Jul 8, 2023
| def repositoryUrl = mavenRepo.rootDir.toURI().toASCIIString() | ||
| // Remove trailing '/' to be consistent with production code | ||
| if (repositoryUrl.endsWith("/")) { | ||
| repositoryUrl = repositoryUrl.substring(0, repositoryUrl.length() - 1) |
Contributor
There was a problem hiding this comment.
Would dropRight(1) work here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maven central repo (https://repo.maven.apache.org/m2) is the default repository URL for any maven PURLs.
For dependencies resolved from Maven central, a repository_url value is no longer included in the generated PURL.
Fixes #43