add password_file when converting to Prometheus basic_auth#82
Closed
rfratto wants to merge 1 commit into
Closed
Conversation
Member
Author
|
This fix isn't sufficient enough to fix all the problems v0.3.0 introduced; see #86. I'm going to close this in favor of a better solution that I'll publish later today. |
rfratto
added a commit
that referenced
this pull request
May 21, 2020
* add yaml hook to not marshal secrets as "<secret>" Fixes #86 Fixes #81 (because it removes the broken) Supplants #82 * replace other uses of yaml marshaling a config with the package methods * add in protection that prevents instance configs from being marshaled directly instance.Configs should always be marshaled to YAML through the marshal functions within the instance package, never using the YAML package directly. * allow "normal" marshaling of instance.Config to keep secrets intact Marshaling without the custom methods will now be slower but will at least work and not unexpectedly remove secrets. Calling the custom methods is still required for scrubbing secrets. * add test to validate instance config marshaling
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* add yaml hook to not marshal secrets as "<secret>" Fixes #86 Fixes #81 (because it removes the broken) Supplants #82 * replace other uses of yaml marshaling a config with the package methods * add in protection that prevents instance configs from being marshaled directly instance.Configs should always be marshaled to YAML through the marshal functions within the instance package, never using the YAML package directly. * allow "normal" marshaling of instance.Config to keep secrets intact Marshaling without the custom methods will now be slower but will at least work and not unexpectedly remove secrets. Calling the custom methods is still required for scrubbing secrets. * add test to validate instance config marshaling
wildum
pushed a commit
that referenced
this pull request
Apr 9, 2024
There is only one release asset, so we don't need nested folders in packaging/.
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81