This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fixed std.setMember() usage #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Collaborator
Author
|
Investigating why the CI failed, while this change worked when I manually tried it. |
Collaborator
Author
|
|
Signed-off-by: Marco Pracucci <marco@pracucci.com>
gouthamve
approved these changes
Aug 7, 2020
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…ber-usage Fixed std.setMember() usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I learned the hard way that
std.setMember()requires the array to be sorted, whilestd.member()doesn't. So far it worked by coincidence, because we were definingstorage_engine: ['chunks', 'tsdb']but after renamingtsdbtoblocksit stopped working as expected. I replaced the usage ofstd.setMember()withstd.member().To use the new function, I've upgraded the jsonnet requirement from
0.14.0to0.15.0.