-
Notifications
You must be signed in to change notification settings - Fork 64
Cleanup ci workflow #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cleanup ci workflow #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7285e2 to
1bdfc4b
Compare
jackw
approved these changes
Sep 25, 2025
Contributor
jackw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, when this repo depended on
grafana/e2e, the CI workflow needed to determine which version of the Grafana packages to install before running e2e tests against a canary Grafana build. With the latest version ofplugin-e2e, this is no longer necessary, as it works across all Grafana versions.This PR removes that legacy step from the CI workflow and cleans up the process overall. It also simplifies the script used to retrieve the latest
grafana-devimage tag. The script is copied from theplugin-actionsrepo. In the future, we may want to move this logic into a composite action for reuse, but for now this approach is sufficient.