"Show disabled items" not working with Direct DB Connection

[mario-zelger]

Describe the bug
I've configured the plugin to use a Direct DB Connection to my mysql Zabbix database. With this setting enabled, the toggle "Show disabled items" no longer has any effect. When the Direct DB Connection is disabled the data for disabled items is loaded as expected.

Expected behavior
When the Direct DB Connection is configured and "Show disabled items" is enabled, I'd expect the data of the disabled items to be shown as well. Maybe I'm missing something here and this scenario is not supported?

Screenshots
Disabled items are loaded when the Direct DB connection is disabled:

Disabled items are not loaded when the Direct DB connection is enabled (same query is used):

Software versions

Grafana	Zabbix	Grafana-Zabbix Plugin
12.2.1	7.4.3	6.0.3

Thanks for your help!

[mario-zelger]

It seems the problem lies within the ZabbixDatasource (src/datasource/datasource.ts) implementation. The target option showDisabledItems is not being passed through to getItemOptions. Without this pass-through, zabbix.getItemsFromTarget will never return disabled items as it is always false when used in the getAllItems method.

grafana-zabbix/src/datasource/datasource.ts

Lines 350 to 359 in 5790b9a

	/**
	* Query target data for Metrics
	*/
	async queryNumericData(target, timeRange, useTrends, request): Promise<any> {
	const getItemOptions = {
	itemtype: 'num',
	};
	const items = await this.zabbix.getItemsFromTarget(target, getItemOptions);

A fix could be to add the showDisabledItems property and use the value from target.options.showDisabledItems. This works in my testing but I do not know if there are other things / side effects to consider when adding this option there.

async queryNumericData(target, timeRange, useTrends, request): Promise<any> {
	const getItemOptions = {
	  itemtype: 'num',
	  // showDisabledItems is not being passed through as an option.
	  // Adding the following line would fix the problem.
	  showDisabledItems: target.options.showDisabledItems
	};

	const items = await this.zabbix.getItemsFromTarget(target, getItemOptions);
        
    // Rest of the code
}

[zoltanbedi]

Thanks for reporting @mario-zelger I was able to reproduce this.