fix(create-plugin): pin @playwright/test to 1.61.x - #2806
Merged
Conversation
tolzhabayev
marked this pull request as ready for review
July 27, 2026 10:24
tolzhabayev
requested review from
eledobleefe and
jackw
and removed request for
a team
July 27, 2026 10:24
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
Collaborator
Author
|
@jackw ptal |
jackw
reviewed
Jul 29, 2026
tolzhabayev
force-pushed
the
fix/pin-playwright-1-61
branch
from
July 29, 2026 07:53
88988e4 to
1b9af99
Compare
Collaborator
|
Urgh... the update command smoke test once again bites us! 😞 Shall we disable it for the time being? |
Collaborator
Author
How about we pin it too for now instead of disabling it? 2500b77 |
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Playwright 1.62 made unresolvable tsconfig
extendspaths a fatal error (microsoft/playwright#41571). Its config loader can't resolve the package specifier in the scaffolded"extends": "@grafana/tsconfig", it only probes paths relative to the extending file, soplaywright testnow crashes on startup for every scaffolded plugin that floats to 1.62. Before 1.62 the unresolved extends was silently swallowed, which is why this never surfaced.This pins
@playwright/testto~1.61.1in the template. Existing plugins manage their own playwright version through renovate/dependabot and won't merge a broken bump, so no migration.Upstream regression report: microsoft/playwright#41989, fixed by microsoft/playwright#42005 which hasn't shipped in a release yet. The pin comes off once it does, tracked in #2805.
Which issue(s) this PR fixes:
Part of #2805 (stays open to track removing the pin)
Special notes for your reviewer:
First seen in grafana/grafana-plugin-examples#721 where all five e2e matrix jobs fail with
Failed to resolve "extends" path "@grafana/tsconfig". Verified by scaffolding a plugin from this branch:@playwright/testresolves to 1.61.1 andplaywright test --listloads the config and tests cleanly.