Add detailed error logging for HTML/PDF generation failures#684
Merged
KrzysztofPajak merged 2 commits intodevelopfrom Apr 29, 2026
Merged
Conversation
…rvice Agent-Logs-Url: https://github.com/grandnode/grandnode2/sessions/53809890-623e-4f82-b022-b85ca5e43b88 Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
KrzysztofPajak
April 29, 2026 18:48
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds structured error logging around Razor view rendering and Scryber PDF generation to improve diagnosability when HTML/PDF output generation fails.
Changes:
- Injected
ILogger<ViewRenderService>and logs view path + partial rendered HTML onRenderAsyncfailures. - Injected
ILogger<HtmlToPdfService>and logs HTML payload whenDocument.ParseDocument/SaveAsPDFfails for order and shipment PDFs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Web/Grand.Web.Common/ViewRender/ViewRenderService.cs | Adds logger injection and logs partial HTML output when view rendering throws. |
| src/Business/Grand.Business.Common/Services/Pdf/HtmlToPdfService.cs | Adds logger injection and logs HTML input when Scryber parse/PDF save throws (orders + shipments). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
KrzysztofPajak
added a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Razor view rendering or PDF generation fails, exceptions are swallowed with no context about what went wrong or what HTML was produced. This makes diagnosing template/data issues very difficult.
Changes
ViewRenderServiceILogger<ViewRenderService>RenderAsyncintry/catch; on failure logs the view path and any partial HTML already written to the buffer before re-throwingHtmlToPdfServiceILogger<HtmlToPdfService>Document.ParseDocument/SaveAsPDFintry/catchfor bothPrintOrdersToPdfandPrintPackagingSlipsToPdf; on failure logs the full HTML passed to Scryber before re-throwing