Revert "Add detailed error logging for HTML/PDF generation failures"#686
Merged
KrzysztofPajak merged 1 commit intodevelopfrom Apr 29, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts #684 by removing the recently added “detailed error logging” around Razor-to-HTML rendering and HTML-to-PDF generation, returning these flows to straightforward exception propagation.
Changes:
- Removed
ILogger<>dependencies fromViewRenderServiceandHtmlToPdfServiceconstructors. - Removed try/catch blocks that logged partial/full HTML content on render/PDF generation failures.
- Restored direct calls to
RenderAsync/ParseDocument/SaveAsPDFwithout additional logging.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Web/Grand.Web.Common/ViewRender/ViewRenderService.cs | Reverts detailed render-failure logging and removes ILogger injection. |
| src/Business/Grand.Business.Common/Services/Pdf/HtmlToPdfService.cs | Reverts PDF-generation failure logging (including HTML content) and removes ILogger injection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _logger.LogError(ex, "Error generating PDF from order HTML. HTML content: {Html}", html); | ||
| throw; | ||
| } | ||
| TextReader sr = new StringReader(html); |
| _logger.LogError(ex, "Error generating PDF from shipment HTML. HTML content: {Html}", html); | ||
| throw; | ||
| } | ||
| TextReader sr = new StringReader(html); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #684