Rename Mongo-specific repository methods to storage-neutral names, reduce overloads#743
Merged
KrzysztofPajak merged 4 commits intoJul 21, 2026
Merged
Conversation
…d reduce overloads AddToSet/UpdateToSet/PullFilter/Pull leaked Mongo terminology and had redundant field==value overloads alongside equivalent predicate-based ones. Renamed to AddToCollectionField/UpdateCollectionFieldItem/ RemoveCollectionFieldItem/RemoveCollectionFieldValue and collapsed the field==value overloads into their predicate equivalents, since a predicate is a strict superset. Also dropped the single-caller, no-id mass-update overload of UpdateCollectionFieldItem in favor of inline logic in ProductTagService, since its Mongo/LiteDb implementations relied on fragile ToString()-based matching. Along the way, fixed a real bug introduced by the merge: LiteDb's predicate-based remove only deleted the first matching array element, while the removed field==value overload (and Mongo's $pull) removed all matches - caught by existing repository unit tests. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
RemoveCollectionFieldValue was a special case of RemoveCollectionFieldItem for IEnumerable<string> fields matched by exact equality - both Mongo's $pull and the predicate-based LiteDb implementation already handle string element types generically, so the dedicated overload added no capability. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IRepository<T>methods that leaked MongoDB terminology to storage-neutral names:AddToSet→AddToCollectionField,UpdateToSet→UpdateCollectionFieldItem,PullFilter→RemoveCollectionFieldItem,Pull→RemoveCollectionFieldValue.field == valueoverloads ofUpdateCollectionFieldItem/RemoveCollectionFieldIteminto their predicate-based (Expression<Func<U, bool>>) equivalents, since a predicate is a strict superset of a field/value pair. ~49 call sites updated accordingly.idmass-update overload ofUpdateCollectionFieldItem(used only byProductTagService.UpdateProductTagto rename a tag across all products); its Mongo/LiteDb implementations relied on fragileToString()-based matching. Replaced with an explicit find +UpdateFieldloop inProductTagService.field == valueoverload (and Mongo's$pull) removes all matches. LiteDb's implementation now removes all matches, consistent with Mongo.This is prep work for keeping the repository abstraction storage-agnostic (no more MongoDB-only method names/shapes in the shared interface).
Test plan
dotnet build GrandNode.sln— 0 errorsGrand.Data.Tests(Mongo + LiteDb repository unit tests) — 45/45 passedGrand.Business.Customers.Tests— 118/118 passedGrand.Business.Catalog.Tests— 349/349 passed (1 pre-existing skip)