Remove unused Grand.Targets.props - #761
Merged
Merged
Conversation
The file has been an empty <Project></Project> since 2022 and nothing imports it - no .csproj, .props, .targets or .sln references it. Projects import Grand.Common.props, which is where the shared TargetFramework, version and source-revision targets actually live. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue
src/Build/Grand.Targets.propshas been an empty<Project></Project>since 2022and nothing imports it - no
.csproj,.props,.targetsor.slnin therepository references it. It reads like shared build configuration and is not.
Found while working through the repository hygiene items in the architecture
roadmap.
Solution
Delete the file.
src/Build/Grand.Common.propsis untouched - that one is imported by projectsand holds the shared
TargetFramework, product version and theSetSourceRevisionId/SetRepositoryBranchtargets.Breaking changes
None. The file is empty and has no importers.
Testing
grep -r "Grand.Targets" --include=*.csproj --include=*.props --include=*.targets --include=*.sln .returns nothing.
dotnet build ./GrandNode.sln- clean.🤖 Generated with Claude Code