feat(magento-customer): forward useFormGqlOptions + mutationOptions on CustomerUpdateForm#2624
Merged
Merged
Conversation
…n CustomerUpdateForm The component already wrapped useCustomerUpdateForm but only passed the attribute-form config through, so consumers had no way to attach an onComplete (close the overlay on a successful save), an onBeforeSubmit (amend or veto variables), or any other useMutation option already supported by the underlying hook — short of dropping down and rebuilding the form layout from scratch. Forward both option bags. Defaults preserve existing behaviour, so the change is backwards compatible. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: cbad1fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomerUpdateFormalready wrapsuseCustomerUpdateFormbut only forwards the attribute-form config. Consumers can't attach anonComplete(e.g. to close an overlay after a successful save), anonBeforeSubmit(amend or veto variables), or any other option supported by the underlyinguseFormGqlMutation/useMutation— short of dropping down and rebuilding the form layout themselves.This PR adds
useFormGqlOptionsandmutationOptionsprops that get forwarded straight through touseCustomerUpdateForm, mirroring the two extra arguments the hook already accepts. Defaults preserve existing behaviour.Why
Coming up in jumbosports we want the
/account/nameoverlay to close after a successful "Save changes" — the canonical GC pattern (if (!errors) router.back()) needs anonComplete. Right now CustomerUpdateForm gives no seam for that.Test plan
<CustomerUpdateForm customer={c} useFormGqlOptions={{ onComplete: (r) => !r.errors && router.back() }} />closes the overlay after a successful updatePick'd fromuseCustomerUpdateForm's exact signature, so any future change to the hook flows through automatically🤖 Generated with Claude Code