[codex] Fix Cypher zero-hop and empty post-aggregate rows#1443
Merged
Conversation
This was referenced May 15, 2026
lmeyerov
force-pushed
the
issue-1369-mixed-wrong-row-tail
branch
from
May 15, 2026 15:33
9d8e916 to
9c618b1
Compare
lmeyerov
force-pushed
the
issue-1369-mixed-wrong-row-tail
branch
from
May 15, 2026 16:16
9c618b1 to
90aebc7
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*0..0preserves the seed node as the zero-length path while keeping the publichop(..., 0)API behavior unchanged.MATCH (a) RETURN count(a) > 0synthesizes the final output column/value.RETURN count(a) = 0, count(a) + 1.tck-gfqlcompanion contract branch.Refs #1369. Refs #1353.
Validation
/tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/test_compute_hops.py::TestComputeHopMixin::test_hop_0b-> 1 passed./tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1369"-> 4 passed, 2 local cuDF skips, 1019 deselected, 4 warnings./tmp/tck-gfql-ci-venv312/bin/python -m pytest -q graphistry/tests/test_compute_hops.py::TestComputeHopMixin::test_hop_0 graphistry/tests/test_compute_hops.py::TestComputeHopMixin::test_hop_0b graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1369 or issue_983 or two_match_reentry_varlen"-> 12 passed, 2 local cuDF skips, 1013 deselected, 4 warnings../bin/ruff.sh graphistry/Plottable.py graphistry/compute/ast.py graphistry/compute/hop.py graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.py-> passed./bin/bash -lc "source /tmp/tck-gfql-ci-venv312/bin/activate && ./bin/typecheck.sh"-> passed.python3 bin/ci_cypher_surface_guard.py-> passed after intentionallowering.pybaseline bump to 9022 lines for the empty post-aggregate projection + amplification fix.RAPIDS_VERSION=25.02 PROFILE=gfql WITH_GPU=1 ... TEST_FILES="<two #1369 cuDF tests>" docker/test-rapids-official-local.sh-> cudf 25.02.02 import smoke; 2 passed.RAPIDS_VERSION=26.02 PROFILE=gfql WITH_GPU=1 ... TEST_FILES="<two #1369 cuDF tests>" docker/test-rapids-official-local.sh-> cudf 26.02.01 import smoke; 2 passed.PYTHONPATH=/home/lmeyerov/Work/pygraphistry4:/tmp/tck-gfql-issue-1369 /tmp/tck-gfql-ci-venv312/bin/python -m pytest -q tests/cypher_tck/test_direct_cypher_contract_fastfail.py tests/cypher_tck/test_report.py-> 8 passed.PYTHONPATH=/home/lmeyerov/Work/pygraphistry4:/tmp/tck-gfql-issue-1369 PYGRAPHISTRY_PATH=/home/lmeyerov/Work/pygraphistry4 PYGRAPHISTRY_INSTALL=0 ./bin/ci.shin siblingtck-gfqlworktree -> 3935 passed, 766 xfailed.graphistry/tck-gfql@issue-1369-mixed-wrong-row-tailis rebased/pushed atbd9107f.origin/master @ 79d62aa5after conflict resolution; pushed head is90aebc74.git diff --check, focused Tranche: mixed wrong-row tail cleanup under #1353 #1369 pytest, ruff touched files, Cypher surface guard, and broader hop/Cypher cluster all passed.2 passedon each).90aebc74is green; merge remains blocked only on required GitHub review.Residual #1369 notes
match5-8andreturn2-10now returnsuccess_matches_expected;expr-aggregation3-1andexpr-mathematical8-1/2were already supported/matches-expected on the current sibling snapshot.expr-pattern1-10,match5-25,match5-26,return2-9, andwith2-1.with2-1appears blocked by sibling fixture/port behavior: the graph fixture materializes(:Begin {num: a.id})as string"a.id", so the expected join value is not available to pygraphistry runtime.return2-9expects duplicate standalone map rows despite current one-row RETURN semantics; likely needs TCK contract/fixture follow-up.