Fix empty post-aggregate list projection#1445
Merged
Merged
Conversation
|
To use Codex here, create an environment for this repo. |
lmeyerov
marked this pull request as ready for review
May 15, 2026 07:17
lmeyerov
force-pushed
the
codex/issue-1367-comparison-list-null
branch
from
May 15, 2026 15:26
d645c1e to
c73b75c
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1367
Refs #1353
Summary
empty_result_row.TCK sidecar
mainafter tck-gfql feature(client path control): specify scheme/authority/path #110 absorbed the prior stacked string-literal base.expr-list12-3plus current-main compatibility promotionreturn2-10.Validation
python3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "issue_1367 and not cudf"5 passedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py -k "(issue_1367 or post_aggregate_size_collect_projection) and not cudf"7 passedpython3 bin/ci_cypher_surface_guard.pylowering.pylines8966 <= 8977./bin/ruff.sh graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/cypher/test_lowering.py./bin/typecheck.sh graphistry/compute/gfql/cypher/lowering.py764 passed, 3705 deselected3935 passed, 763 xfailedtck-gfqlagainst sidecar commitb9d79b6testspassDGX / cuDF
dgx-sparkviadocker/test-rapids-official-local.sh, narrow selector:test_issue_1367_empty_optional_match_post_aggregate_list_comprehension_size_on_cudftest_issue_1367_post_aggregate_list_projection_counts_existing_relationships_on_cudf2 passed2 passeddgx-sparkis shared; GPU was visible asNVIDIA GB10, utilization0 %, memory fieldsN/A.Review
agents/skills/review/SKILL.mdin findings mode through convergence.plans/issue-1367-comparison-list-null/review/followup-2026-05-15/final-report.md.