Skip to content

test(gfql): sibling-specialization sweep pins (#2051) - #2052

Merged
lmeyerov merged 2 commits into
masterfrom
test/gfql-sibling-sweep-pins
Sep 5, 2026
Merged

test(gfql): sibling-specialization sweep pins (#2051)#2052
lmeyerov merged 2 commits into
masterfrom
test/gfql-sibling-sweep-pins

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Test-only, stacked on #2046 (retargets to master when it lands).

Owner ask after #2046: a fix for one specialization may be needed on its siblings; audit the recent fixes. The sweep (25 merged fix PRs inventoried; the engine- or lane-specific ones re-probed on pandas, cuDF and polars × scan/indexed × native/Cypher/hop/multi-hop against the pandas full path; report in the campaign plan under spec-sweep/) found one more miss beyond the #2039 family already handled in #2046:

This PR pins that contract in the polars mirror directory: the collapsing shapes green against pandas, the two leaking shapes as strict expected failures that flip with the fix. Registered in the polars test lane.

Classes re-probed clean on every engine × policy: #1990 EXISTS with indexes, #2000/#1991 bag multiplicity, #2002/#1982 boolean aggregates, #1998 IN/equality over categorical (string predicates over categorical raise the same E302 on every engine — consistent, flagged as a usability question in the report).

🤖 Generated with Claude Code

https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA

… single-hop shape (#2051)

Sibling-specialization sweep after #2046: polars' hop() collapses duplicate node rows
(#1993) but the unnamed, untyped single-hop chain shape still keeps the duplicate. The
collapsing shapes (named, typed, hops=2, undirected, hop()) are pinned green against
pandas; the two leaking shapes are strict expected failures that flip with the fix.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA
@lmeyerov
lmeyerov force-pushed the test/gfql-sibling-sweep-pins branch from ea1f455 to 40a7d64 Compare September 5, 2026 21:04
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

READY (40a7d64) — re-stacked on #2046's current head; CI 75/75 check-runs success. Test-only: #2051 strict-xfail pin + collapsing shapes green.

…every lane and engine

The #2039 class probed on the routes the native collision matrix does not reach: the
Cypher seeded typed-hop and node-lookup lanes, whole-entity return, the two-hop count lane,
the lowered full path, and the native rows route — all match the pandas full path on
pandas, cuDF and polars, scan and indexed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QztW7jYsDd66e8rb8pJNQA
Base automatically changed from fix/gfql-2039-polars-alias-collision to master September 5, 2026 21:43
@lmeyerov

lmeyerov commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

READY (67413cf) — now on master after #2046 landed; CI 75/75 check-runs success. Test-only: #2051 strict-xfail pin + collapsing shapes, and the Cypher-lane / rows-route collision pins (8 shapes × 3 engines × scan/indexed).

@lmeyerov
lmeyerov merged commit 86de0f5 into master Sep 5, 2026
76 checks passed
@lmeyerov
lmeyerov deleted the test/gfql-sibling-sweep-pins branch September 5, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant