fix: monolith promotion to empty target - #8376
Merged
Merged
Conversation
n1ru4l
force-pushed
the
fix-monolith-schema-promotion-to-other-target
branch
from
August 17, 2026 09:42
9573fac to
ce9ba76
Compare
Collaborator
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
n1ru4l
force-pushed
the
fix-monolith-schema-promotion-to-other-target
branch
from
August 17, 2026 10:13
ce9ba76 to
08bba87
Compare
…fs to avoid invariant assertions intended for monolithic schemas
n1ru4l
force-pushed
the
fix-monolith-schema-promotion-to-other-target
branch
from
August 17, 2026 10:45
6bd5a80 to
2d7ad66
Compare
n1ru4l
marked this pull request as ready for review
August 17, 2026 10:57
dotansimha
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a monolith schema promotion to an empty target (no prior published schema) raise an internal server error.
The logic had flaws for handling the monolith schema correctly. Instead of bending the implementation to cover both composite and monolith, we now shortcut in the monolith scenario as most of the additional information we store is not needed anyways.