Expect only first parameter as List in Batched #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaveLiArcH
changed the title
PaveLiArcH
changed the title
|
Thanks for the PR - would you mind adding a test that ensures this won't break in the future? |
apottere
reviewed
Jan 12, 2018
|
|
||
| if(realType is ParameterizedType && isListType(realType, potentialMatch)) { | ||
| return potentialMatch.copy(javaType = realType.actualTypeArguments.first(), batched = false) | ||
| if (potentialMatch.location.ordinal > 0) { |
There was a problem hiding this comment.
I think this is checking the enum ordinal, not the method parameter position.
There was a problem hiding this comment.
Changed this to compare with enum
|
Added test to check batched method with parameters |
|
Just faced the same issue this PR fixes, any rough ETA on Maven Central? |
|
Any updates? |
|
Thanks for merging @apottere! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only first argument should be List (this fixes #93)