Skip to content

Add @semanticNonNull draft#49

Merged
martinbonnin merged 2 commits into
mainfrom
semantic-non-null
Jun 3, 2026
Merged

Add @semanticNonNull draft#49
martinbonnin merged 2 commits into
mainfrom
semantic-non-null

Conversation

@martinbonnin
Copy link
Copy Markdown
Contributor

@martinbonnin martinbonnin commented Jun 2, 2026

I currently use https://specs.apollo.dev/nullability/v0.4/#@semanticNonNull as reference but GAPs feel like a better place.

Also, contrary to onError, I don't necessarily expect that @semanticNonNull makes it to the main spec since it's mainly used for compatibility. Hence me opening that GAP. Let me know what you think!

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jun 2, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
gaps 4d7594a Jun 02 2026, 04:40 PM

Comment thread gaps/GAP-49/metadata.yml
- name: "Martin Bonnin"
email: "martin@apollographql.com"
githubUsername: "@martinbonnin"
sponsor: "@martinbonnin"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @captbaritone, @itamark, feels like you should be here. Is it OK if I add you?

Copy link
Copy Markdown
Contributor

@magicmark magicmark Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinbonnin sponsors have to be part of @graphql/gaps-editors (in order to have write access on this repo). You are also able to be your own sponsor.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good everything works for me. I'm down to merge this and we can add Jordan/Itamar later on if/when they want.

@martinbonnin
Copy link
Copy Markdown
Contributor Author

@magicmark can you see why Cloudflare workers build is not happy?

Copy link
Copy Markdown
Contributor

@magicmark magicmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinbonnin would you mind running npm run build to make sure the spec is valid spec-md and the website will build?

(or if you wanna give a 🚢 this will happen automagically #34)

deploy previews might take a little longer, still wip here #40

@martinbonnin
Copy link
Copy Markdown
Contributor Author

npm run build worked. Trying to merge to see ig that goes through 🤞

@martinbonnin martinbonnin merged commit c0b1b8c into main Jun 3, 2026
2 of 3 checks passed
@martinbonnin
Copy link
Copy Markdown
Contributor Author

Looks like that didn't work... digging into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants