Skip to content

Cleanup & Improve examples#1975

Merged
acao merged 3 commits intographql:mainfrom
acao:docs/examples-cleanup
Oct 13, 2021
Merged

Cleanup & Improve examples#1975
acao merged 3 commits intographql:mainfrom
acao:docs/examples-cleanup

Conversation

@acao
Copy link
Copy Markdown
Member

@acao acao commented Oct 11, 2021

  • shared webpack and babel config for examples (does this detract from the replicability of examples?) to cut down on boilerplate
  • improve monaco example to explain the github login
  • add examples for createFetcher
  • should we just move all examples to codesandbox???!? or is this better? hmmm!!
  • remove yarn build from yarn build-bundles prebuild step, speeding up buildtimes

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 11, 2021

⚠️ No Changeset found

Latest commit: 8911517

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 11, 2021

Codecov Report

Merging #1975 (8911517) into main (2d91916) will increase coverage by 0.75%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   65.70%   66.45%   +0.75%     
==========================================
  Files          85       86       +1     
  Lines        5106     5143      +37     
  Branches     1631     1640       +9     
==========================================
+ Hits         3355     3418      +63     
+ Misses       1747     1721      -26     
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 50.90% <20.00%> (-8.67%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
packages/graphiql/src/components/QueryHistory.tsx 73.91% <76.47%> (+6.69%) ⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
...raphql-language-service-server/src/GraphQLCache.ts 52.25% <0.00%> (+0.60%) ⬆️
packages/graphiql/src/utility/QueryStore.ts 42.85% <0.00%> (+2.04%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add998f...8911517. Read the comment docs.

@acao acao merged commit 880ea06 into graphql:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant