[lsp] Fix parsing of relay style locations in locateCommand results

[hayes]

Currently locateCommand is described as accepting "relay style" locations, which are interpreted as uri:startLine:endLine.

Relay actually uses uri:line:column which aligns with with how locations are represented in stack traces.

The values are also being interpreted as 0 indexed, when I believe they are actually 1 index in relay and stack traces

[changeset-bot]

⚠️ No Changeset found

Latest commit: d841150

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hayes / name: Michael Hayes (d841150)

[hayes]

cc @captbaritone

[captbaritone]

This looks right to me. Thanks for opening the PR @hayes!

I opened #3895 before I saw this one. I've closed it in favor of this one which also fixed the 1 based indexing, but I'll copy some of the description from mine:

Our intention in Relay was for the response from the locate command to be treated as path:line:column to match the convention of path strings in CLI output used by most tools. For example, paths in stack traces or errors in compiler output.

This convention is a de facto standard understood by many terminal emulators. This means if a server implements a locate command it should be useful in GraphQL LSPs (like this one or Relay's) and also at the CLI, where a user could manually invoke the command and then cmd+click the result to jump to the correct location in their editor.

Screen.Recording.2025-04-25.at.9.25.20.AM.mov

[captbaritone]

I can also confirm that path:line:column with 1-based indexing is what Grats returns: https://grats.capt.dev/docs/getting-started/cli/#locate