Fix vsix download path in publish job#4267
Merged
trevor-scheer merged 2 commits intoMay 14, 2026
Merged
Conversation
`actions/upload-artifact@v4` strips the path prefix up to the first wildcard, so `packages/vscode-graphql*/*.vsix` only preserves `vscode-graphql*/<file>` in the artifact. The publish script looks under `vsix/packages/<pkg>/`, so the download path needs the `packages/` prefix restored. Patch-bumps the three VSCode extension packages so the next release exercises the publish path.
🦋 Changeset detectedLatest commit: fee433f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This was referenced May 14, 2026
trevor-scheer
pushed a commit
that referenced
this pull request
May 15, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## monaco-graphql@1.8.0 ### Minor Changes - [#4264](#4264) [`227f5ba`](227f5ba) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Add `./monaco-editor` to the `exports` map. `monaco-graphql/monaco-editor` re-exports `monaco-editor` with only the graphql and json languages, skipping the css, html, and typescript contributions that the default `monaco-editor` entry point bundles. Consumers can use it to share a single `monaco-editor` instance with `monaco-graphql` (for `editor`, `Uri`, `KeyMod`, `KeyCode`, `languages`, etc.) without paying for those extras. Until now you had to reach for the unstable `monaco-graphql/esm/monaco-editor` path, which only resolves under legacy `node10`-style module resolution. The legacy `monaco-graphql/esm/monaco-editor` path still works via the existing `./*` wildcard, so this change is purely additive. The `monaco-graphql/esm/*` import pattern is now considered deprecated. It will continue to work throughout the `1.x` line, but the wildcard `exports` entry that enables it is planned for removal in the next major version. New code should prefer the canonical paths: `monaco-graphql/monaco-editor`, `monaco-graphql/initializeMode`, `monaco-graphql/graphql.worker`, and `monaco-graphql/lite`. ## codemirror-graphql@2.2.6 ### Patch Changes - [#4274](#4274) [`d23f3b1`](d23f3b1) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Bump TypeScript emit target from `es5` to `es6`. The published JavaScript now uses ES6 syntax (`const`, arrow functions, native destructuring) instead of down-leveled ES5. In practice this is consumed via a bundler in every real-world setup (and paired with CodeMirror 5, which already requires an ES6 runtime), so this changes the intermediate emit but not what consumers end up shipping. Code that loads the published `.js` directly in a strictly ES5-only environment (e.g. IE11 without transpilation) is no longer supported. CodeMirror 5 itself does not support that configuration. ## @graphiql/react@0.37.5 ### Patch Changes - [#4232](#4232) [`3934e4a`](3934e4a) Thanks [@simmerer](https://github.com/simmerer)! - Bugfix for multiline selection highlight styling: disabling Monaco's `roundedSelection` option prevents selection highlight from appearing to extend beyond actual text selection. See issue [#4094](#4094). - Updated dependencies \[[`227f5ba`](227f5ba)]: - monaco-graphql@1.8.0 ## vscode-graphql@0.13.5 ### Patch Changes - [#4267](#4267) [`e4f5148`](e4f5148) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning patch version due to previous release failure. ## vscode-graphql-execution@0.3.5 ### Patch Changes - [#4267](#4267) [`e4f5148`](e4f5148) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning patch version due to previous release failure. ## vscode-graphql-syntax@1.3.11 ### Patch Changes - [#4267](#4267) [`e4f5148`](e4f5148) Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning patch version due to previous release failure. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The vsix publish jobs failed with
ENOENTin the last release.actions/upload-artifact@v4strips the path prefix up to the first wildcard segment, sopackages/vscode-graphql*/*.vsixonly preservesvscode-graphql*/<file>in the artifact — but the publish script looks undervsix/packages/<pkg>/. Setting the downloadpathtovsix/packageslines things back up.A patch changeset re-bumps the three VSCode extensions so the next release exercises the publish path.
Failed run: https://github.com/graphql/graphiql/actions/runs/25878625719
Test plan
Only exercisable by a real release. The previous run's
attachstep succeeded, so0.13.4/1.3.10/0.3.4can still be manually uploaded from the GitHub Release.vsixassets viavsce publishandovsx publishif those versions are wanted on the marketplaces.