v6: Restyle Button and ToolbarButton#4276
Merged
Merged
Conversation
Migrates button component CSS to v6 OKLCH tokens and adds a `primary` variant to `Button` for the Run-button style (green fill, white text, weight 600). Execute-button CSS updated to match. Storybook stories added covering default, primary, success, error, and disabled states. Props and runtime behavior unchanged.
🦋 Changeset detectedLatest commit: f5394a8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Add `autodocs` to custom-words.txt - Convert `Button` stories to render functions so the `.tsx` file contains JSX (oxlint rule) - Use opaque accent colors with white text on the `success` and `error` variants so they meet WCAG AA contrast
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Button,UnStyledButton,ToolbarButton, andExecuteButtonCSS to v6 OKLCH tokens.variant?: 'default' | 'primary'toButton;primaryrenders the Run-button style.:focusto:focus-visibleon interactive states so the focus ring no longer fires on mouse click. Aligns with MDN:focus-visibleand WCAG 2.4.7 (Focus Visible).clsxdirectly inbuttonandtoolbar-button, following the leaf-module pattern from Import directly from leaf modules ingraphiql-reactto fix Rollup chunk cycles #4272. A follow-up PR will convert remaining callers and remove thecnre-export.Primitives/Button(Default, Primary, Success, Error, Disabled) andPrimitives/ToolbarButton(Default).Test plan
Primitives/Buttonand verify each variant matches the design.Primitives/ToolbarButton. Hover the icon button; a v6 tooltip appears.yarn dev:graphiql. The Run button and toolbar buttons match the new design.Refs: #4219