v6: Add KeycapHint primitive#4277
Merged
Merged
Conversation
A small inline component for keyboard-shortcut chips, used by the new top bar's command palette and Run buttons. Renders one or more `<kbd>` elements with the v6 keycap styling. The required `ariaLabel` prop ensures every chip has a screen-reader-readable description. Adds `@testing-library/react` + `jest-dom` to `@graphiql/react`'s devDependencies to support component unit tests in this package.
🦋 Changeset detectedLatest commit: eb0ae81 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Add `autodocs` to custom-words.txt - Convert `KeycapHint` stories to render functions so the `.tsx` file contains JSX (oxlint rule)
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeycapHintfor inline keyboard-shortcut chips.<kbd>elements with the v6 keycap visual.ariaLabelensures every shortcut chip has a screen-reader-readable description.@testing-library/react+@testing-library/jest-domas devDeps; these are the first component unit tests in@graphiql/react.Test plan
Primitives/KeycapHint. Each variant renders with the v6 chip style.aria-labelon each story root; screen-reader spot-check is optional.Refs: #4219