v6: Restyle Tooltip#4278
Merged
Merged
Conversation
Updates tooltip styles to consume v6 OKLCH tokens. Adds a `--shadow-popover` token to tokens.css so future popover-family components share the same shadow recipe.
🦋 Changeset detectedLatest commit: e75ac0d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TooltipCSS to v6 OKLCH tokens (--bg-elevated,--border-default,--fg-default).--shadow-popovertotokens.css(dark + light variants) and use it inTooltip. Future Dialog and DropdownMenu PRs reuse this token.font-sizeto--font-size-small(11px) rather thaninherit: tooltips are floating UI primitives and should render at a consistent size regardless of where they're anchored.Primitives/Tooltip(Default + TopPlacement).Test plan
Primitives/Tooltipand verify both Default and TopPlacement render correctly.data-theme="light"on the Storybook root). Shadow should soften for the lighter surface.Refs: #4219