v6: Restyle Tabs#4281
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3eeba5c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
force-pushed
the
trevor/restyle-tabs
branch
2 times, most recently
from
11b7279 to
7cf1ee6
Compare
Switch tab strip styles to v6 OKLCH tokens. Active tabs get a top blue border that overlaps the strip's bottom border; inactive tabs use a dimmer text color.
Decorator wraps stories in a `.graphiql-container` and now sets that container (and the body) to the active theme's `--bg-canvas` and `--fg-default`. Without an opaque themed ancestor, axe-core walks up to the browser-default white body and contrast checks fail against any theme-aware text. This makes stories look like the real app and lets a11y tests evaluate the right surface.
trevor-scheer
force-pushed
the
trevor/restyle-tabs
branch
from
7cf1ee6 to
3eeba5c
Compare
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Primitives/Tabs; check both stories.Refs: #4219