v6: Add SidePanel component#4291
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1b19a4d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
trevor-scheer
force-pushed
the
trevor/sidepanel-component
branch
2 times, most recently
from
e99a938 to
96dd313
Compare
Hosts the active plugin's `content` ReactNode in a 340px-wide panel next to the activity rail. Renders nothing when no plugin is active. Width is user-resizable via the existing drag handle.
Splits the connected `SidePanel` from a pure `SidePanelView`. The unit tests now render `SidePanelView` directly, sidestepping the monaco teardown errors that `GraphiQLProvider` triggers in jsdom.
trevor-scheer
force-pushed
the
trevor/sidepanel-component
branch
from
96dd313 to
1f1eeb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
SidePanelthat hosts the active plugin's content next to the new activity rail. The panel renders nothing when no plugin is active, and remains user-resizable via the existing drag handle. Together with the activity rail change, it completes the left-side navigation chrome for the v6 layout.Test plan
Refs: #4219