v6: Replace Monaco editor themes with v6 token palette#4297
Merged
Conversation
Replaces the old hot-pink `primary`/`primaryBg`/`bg`/`secondary` color palette in `MONACO_THEME_DATA` with values from the v6 OKLCH token table. Both `graphiql-DARK` and `graphiql-LIGHT` now carry explicit token rules for every token type the Monaco GraphQL grammar emits: keywords, type names, field identifiers, `$variable` arguments, `@directive` annotations, strings, numbers, operators, and comments. Comments are italicized. UI chrome colors (suggest widget, hover widget, quick input, focus ring) follow the v6 `--accent-green` slot instead of the old pink. Adds `monaco-themes.test.ts` to lock down the token rule shapes.
Replaces `hsl(var(--color-primary))` with `oklch(var(--accent-green))` in the Monaco `.highlight` and `input:focus-visible` rules. Adds the `EAEEF` hex fragment to the cspell dictionary to clear the lint warning introduced by the light-theme bg-overlay constant.
🦋 Changeset detectedLatest commit: 84c4a7f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MONACO_THEME_DATAinconstants.ts: bothgraphiql-DARKandgraphiql-LIGHTnow cover all GraphQL token types (keywords, types, fields,$variables,@directives, strings, numbers, operators, comments) using the v6 accent palette.--color-primaryto--accent-green.editor.css: swapshsl(var(--color-primary))foroklch(var(--accent-green))in the.highlightandinput:focus-visiblerules.monaco-themes.test.tsto pin token rule shapes for both themes.Test plan
Refs: #4219