v6: Show operation pill on History rows#4316
Merged
Merged
Conversation
Renders `ERR` for items where the operation type isn't known.
`QueryStoreItem` gains an optional `operation` field, populated at write time from the parsed query. The history row uses `MethodPill` to surface it; legacy entries render `ERR`. The clear button drops the `success`/`error` state machine; rows disappearing is the feedback.
🦋 Changeset detectedLatest commit: 3e7afb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Items only enter history if their query parses; an `operation` is always captured at write time. The only way `item.operation` is missing is legacy localStorage entries, which now render without a pill (they age out as history rotates).
Single source of truth in toolkit (where it backs `QueryStoreItem.operation`); `MethodPill` imports and re-exports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MethodPill(QRY/MUT/SUB) per History row in place of the green status dot.QueryStoreItemgains an optionaloperationfield, populated at write time from the parsed query.Test plan
Mixedstory.Refs: #4219