Fix some input objects missing from the type map#117
Merged
leebyron merged 1 commit intographql:masterfrom Aug 11, 2015
Merged
Conversation
Input object types were not included in the type map when they were used as a field type in other input objects, because `typeMapReducer` did not recurse into those fields. Modify `typeMapReducer` to also handle GraphQLInputObjectType and add a test case that checks also nested input object types are handled.
Contributor
|
Thank you for diagnosing and fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input object types were not included in the type map when they were used as a field type in other input objects, because
typeMapReducerdid not recurse into those fields.Modify
typeMapReducerto also handle GraphQLInputObjectType and add a test case that checks also nested input object types are handled.