temporarily revert cancellation#4535
Merged
yaacovCR merged 1 commit intographql:nextfrom Jan 27, 2026
Merged
Conversation
yaacovCR
added
the
PR: breaking change 💥
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing version of cancellation yields partial results, which is really resolver cancellation, something that can be done in user space.
This was (probably?) a mistake.
The plan is to re-implement cancellation as an abrupt termination, i.e. execute will throw when abortSignal triggers.
This PR first reverts the current work to demonstrate the feature more cleanly in the follow-on PR.