fix(execution): convert all promise-like results to promises#4672
Merged
yaacovCR merged 1 commit intographql:17.x.xfrom Apr 19, 2026
Merged
fix(execution): convert all promise-like results to promises#4672yaacovCR merged 1 commit intographql:17.x.xfrom
yaacovCR merged 1 commit intographql:17.x.xfrom
Conversation
previously, most pathways converted, but not all this actually brings a small perf improvement!
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, most pathways converted, but not all
in particular, pathways branching off of
isTypeOf(...)andresolveType(...)as well ascreateSourceEventStreamcould return non-native promises even though we advertisedPromiseOrValue.There is also a micro-benchmark perf improvement even in sync paths, presumably because V8 can make a few more assumptions.