Skip to content

Conversation

@skevy
Copy link
Contributor

@skevy skevy commented Sep 10, 2015

No description provided.

@wincent
Copy link
Contributor

wincent commented Sep 10, 2015

Thanks! I think it's probably worth updating the test cases to exercise this functionality. What do you think?

@skevy
Copy link
Contributor Author

skevy commented Sep 11, 2015

Just realized this relates to #22...

How does an array work in this case (as opposed to an object or a thunk)? What's the purpose?

cc @dschafer

@dschafer
Copy link
Contributor

How does an array work in this case (as opposed to an object or a thunk)? What's the purpose?

I meant thunk or object. Too much time in PHP!

@skevy
Copy link
Contributor Author

skevy commented Sep 11, 2015

@dschafer ha. Ok. Well then this should do it then :)

@wincent
Copy link
Contributor

wincent commented Oct 23, 2015

Sorry for letting this sit here and go stale, @skevy. Would you be able do rebase so that I can merge this in cleanly?

@wincent wincent self-assigned this Oct 23, 2015
@skevy
Copy link
Contributor Author

skevy commented Nov 9, 2015

Very sorry I let this sit! LGTM :) /cc @wincent

@skevy
Copy link
Contributor Author

skevy commented Nov 29, 2015

Any update on this @wincent @kassens @dschafer ?

@dschafer dschafer merged commit 8c9c898 into graphql:master Dec 9, 2015
@dschafer
Copy link
Contributor

dschafer commented Dec 9, 2015

Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants