Highlight that the name is a recommendation

[martinbonnin]

A specification mentions a "recommended" name but users are free to use other values. The recommended name also doesn't have to match the url path segment.

Follow up from #34

[andimarek]

Looks good, but I would apply the changes suggested by @glen-84

[martinbonnin]

Thanks for the review @glen-84!

[glen-84]

If the templates are changed, then all existing specs should be updated to match.

[martinbonnin]

then all existing specs should be updated to match.

I would push back from that. Changing the existing specs without the authors approval sounds not nice. And contacting them and getting their approval is a lot of effort (well, maybe not today because it's only @andimarek contributing but in the future, that's not something I'm really keen on doing)

[glen-84]

Well ...

1. It's a minor change. You wouldn't contact the authors if you fixed a typo, and adding "Recommended" in front of "name" doesn't change the specs in any fundamental way.
2. If it's worth changing in the template, then it's worth changing everywhere.
3. The existing specs should be based on the templates.
4. Not changing them creates the kind of inconsistency that I tried to resolve in Minor improvements #31.

[martinbonnin]

You wouldn't contact the authors if you fixed a typo

I think I would. For an example, https://scalars.graphql.org/andimarek/ is Andi's space on the GraphQL internet. Feels weird to change it without his permission, even for just a typo.

Older specs will become inconsistent but I think this is fine.

GraphQL has overindexed on quality and this has driven a number of contributors out. I'm not saying we should break everything but some chaos in this repo is perfectly fine by me as long as it allows us to move faster.

[glen-84]

I think I would. For an example, https://scalars.graphql.org/andimarek/ is Andi's space on the GraphQL internet. Feels weird to change it without his permission, even for just a typo.

You would contact Andi for permission to change appple to apple? 😜

This isn't Geocities, these are formal standards referenced by many (we hope).

Older specs will become inconsistent but I think this is fine.

This will cause fragmentation over time, at which point the templates become less useful. But anyway, it's just a suggestion. 🙂

[martinbonnin]

You would contact Andi for permission to change appple to apple?

I would :). It's not about the magnitude of the change, it's about setting clear ownership.

My desk is typically a mess but it's "my" mess. I'd be mad if someone cleans it up!

it's just a suggestion

If you're ok with that specific change, do you mind changing your review to "comment" or "approve" so that we can move forward? Given I have @andimarek approval I think we can merge this if you don't have a strong objection.

Feel free to open a follow up PR to keep the existing scalars in check.