Skip to content

[RFC] Add support for directives for an object field name #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francisu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[RFC] Add support for directives for an object field name #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52743e8
Allow directives on arguments, object fields
francisu Apr 7, 2020
f089b0b
Allow directives on object fields
francisu Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/Appendix B -- Grammar Summary.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ ObjectValue[Const] :
- { }
- { ObjectField[?Const]+ }

ObjectField[Const] : Name : Value[?Const]
ObjectField[Const] : Directives? Name : Value[?Const]

VariableDefinitions : ( VariableDefinition+ )

Expand Down Expand Up @@ -322,6 +322,7 @@ ExecutableDirectiveLocation : one of
`FRAGMENT_SPREAD`
`INLINE_FRAGMENT`
`VARIABLE_DEFINITION`
`OBJECT_FIELD`
Copy link
Contributor

@sungam3r sungam3r Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that changes the meaning of FIELD location. Does new location make sense?

Copy link
Contributor Author

@francisu francisu Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it changes anything about the FIELD location. FIELD and OBJECT_FIELD are unrelated. But I have a feeling I'm missing your point. Can you say more?

Copy link
Contributor

@sungam3r sungam3r Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between FIELD and OBJECT_FIELD ?

Copy link
Contributor Author

@francisu francisu Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIELD refers to a GraphQL field (see section 2.5 of the spec). OBJECT_FIELD refers to a GraphQL ObjectField (2.9.8). They have nothing to do with each other. If you look at the proposed grammar change, the directive is supposed before the Name element of the ObjectField.

Copy link
Contributor Author

@francisu francisu Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this confusion and make the spec easier to understand, it would be helpful to refer to the section in the spec where each of these items refer to. I will make a separate PR for that.

Copy link
Contributor

@sungam3r sungam3r Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Now I understand. At first I thought about something completely different.


TypeSystemDirectiveLocation : one of
`SCHEMA`
Expand Down
2 changes: 1 addition & 1 deletion spec/Section 2 -- Language.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,7 @@ ObjectValue[Const] :
- { }
- { ObjectField[?Const]+ }

ObjectField[Const] : Name : Value[?Const]
ObjectField[Const] : Directives? Name : Value[?Const]

Input object literal values are unordered lists of keyed input values wrapped in
curly-braces `{ }`. The values of an object literal may be any input value
Expand Down
1 change: 1 addition & 0 deletions spec/Section 3 -- Type System.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,6 +1734,7 @@ ExecutableDirectiveLocation : one of
`FRAGMENT_SPREAD`
`INLINE_FRAGMENT`
`VARIABLE_DEFINITION`
`OBJECT_FIELD`

TypeSystemDirectiveLocation : one of
`SCHEMA`
Expand Down